Conversation
lidel
force-pushed
the
feat/migrate-cid-v0-to-cid-v1
branch
from
1d12cb0 to
5870a24
Compare
| logger.info('[enable-cid-v1]: Enabling CID version 1 for files') | ||
| try { | ||
| // @ts-expect-error - ipfsd.api is not typed properly | ||
| await ipfsd.api.files.chcid('/', { cidVersion: 1 }) |
There was a problem hiding this comment.
In addition to this, should also set Import.* in config to apply CIDv1 to files imported via context menu in Windows Explorer's right-click context menu (which uses ipfs add).
See thoughts in ipfs/kubo#4143 (comment) – my current thinking is that we want to avoid breaking existing users, and in next verison of Kubo we will explicitly save defaults in Import on repo creation.
IPFS Desktop could follow this philosophy (or just wait for Kubo) – initialize new users with CIDv1 and store that in Import.*, and for old users who have Import.CidVersion=0 or unset give them context menu for switching to CIDv1, which would switch + set Import.CidVersion=1 and other values.
This way we won't break anyone, but still be able to move forward.
There was a problem hiding this comment.
i'd much rather just pull in settings directly from kubo and have things work there if we can
There was a problem hiding this comment.
Yes, I think we need a fix in Kubo. It should respect Import.* especially Import.CidVersion when a new MFS root is created. (TODO: fill issue once im at PC)
5 participants
Fixes: #2361