Fix color artifacts in PointCloud projection due to CUDA race condition#7424
Open
ManuCorrea wants to merge 5 commits intoisl-org:mainfrom
Open
Fix color artifacts in PointCloud projection due to CUDA race condition#7424ManuCorrea wants to merge 5 commits intoisl-org:mainfrom
ManuCorrea wants to merge 5 commits intoisl-org:mainfrom
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Author
|
I will add testing and the changes in CHANGELOG.md in the following days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
It solves the artifacts described in #6612 which happen to be because a race condition on the CUDA code.
The existing ProjectCUDA implementation suffered from a race condition in the color assignment pass. Multiple threads with similar depths in the color assignment pass (within the precision_bound) could simultaneously pass the depth test and write to the RGB color buffer, leading to the artifacts shown in the mentioned issue.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
To fix it I implemented a buffer to keep track in the pass 1 of which worker should write to the color tensor in the pass 2.
Pass 1 (Depth & Index Acquisition):
Pass 2 (Deterministic Color Assignment):
Old graph from the issue:

My results:
