Don't select closed/closing connections in the pool#417
Merged
isoos merged 4 commits intoisoos:masterfrom Feb 21, 2025
Merged
Conversation
Contributor
Author
|
The error appears to be random, and the server is serving multiple requests in between the error timestamps. Same environment as the one described in #414 Requests, even the failed ones, are resolved in a timely manner though:
|
isoos
reviewed
Feb 21, 2025
davidmartos96
force-pushed
the
dont_select_closed_conn
branch
from
bd45740 to
7b5c1e1
Compare
Owner
|
Thank you! Published as 3.5.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, after updating to Dart 3.7 I started noticing the following error. I haven't been able to try lowering the Dart version, but I did try a possible patch in the library that makes it work.
My understanding is that the pool is picking a connection that is closed or closing, so it will fail when trying to use it. I've tried deploying this fix in the server as it seemed low risk and I haven't seen the error since.
Deployed postgres from pub again and they start showing up again.