-
Notifications
You must be signed in to change notification settings - Fork 1
chore(ci): limit ci-fast/extended to workflow_call #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
Auto Update BranchPR #1812 was behind base; triggered branch update. |
Quality Summary
|
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b48b8552a3ef0378dad3d763488a14d8b3a0ebb2/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/6857b9c276a51cfd2fc4c22cdb1e2d83e9035aa7/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b48b8552a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes workflow_dispatch triggers from ci-fast.yml and ci-extended.yml as part of the CI consolidation effort described in issue #1006. The goal is to make these workflows reusable only (via workflow_call), with ci.yml serving as the single entry point for triggering CI workflows.
Changes:
- Removed
workflow_dispatch:trigger from ci-fast.yml - Removed
workflow_dispatch:trigger from ci-extended.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci-fast.yml | Removed workflow_dispatch trigger to limit to workflow_call only |
| .github/workflows/ci-extended.yml | Removed workflow_dispatch trigger to limit to workflow_call only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodeX Artifacts Summary
|
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/77888218ccc22d476c2fbbc3ae3bf2871e956625/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
CodeX Artifacts Summary
|
Summary
Testing
Related