-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ci): reduce 429 flakiness (gh retries) #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
Quality Summary
|
Progress Summary
|
Generate Artifacts PreviewGenerated at: 2026-02-11T09:52:25.925Z
|
|
@artifacts/quality/comment-body.txt |
KvOnce Trace Validation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 779070a716
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the resilience of CI scripts against GitHub API rate limiting (HTTP 429 errors) by strengthening the retry logic and migrating a script to use the centralized retry mechanism.
Changes:
- Increased default retry attempts from 6 to 8 and max delay from 30s to 60s in
gh-exec.mjs - Added "exceeded retry limit" as a retryable error pattern to handle GitHub CLI's internal retry failures
- Added opt-in debug logging via
AE_GH_RETRY_DEBUG=1environment variable - Migrated
post-envelope-comment.mjsfrom directspawnSynctoexecGhwrapper for automatic retry support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/ci/lib/gh-exec.mjs | Enhanced retry configuration (8 attempts, 60s max delay), added "exceeded retry limit" pattern to retry logic, added debug logging support |
| scripts/trace/post-envelope-comment.mjs | Migrated GitHub comment posting from spawnSync to execGh wrapper for retry support, updated error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
|
@artifacts/quality/comment-body.txt |
429/secondary rate limitで
ghが失敗→異常停止する事象が再発したため、耐性を追加しました。\n\n- scripts/ci/lib/gh-exec.mjs: デフォルトリトライを強化(attempts 8 / maxDelay 60s)、exceeded retry limit文言もretry対象に追加、必要時のみAE_GH_RETRY_DEBUG=1で待機ログ出力\n- scripts/trace/post-envelope-comment.mjs: GitHubコメント投稿をexecGh経由に変更(stdin pipe + stdout/stderr inherit)\n\n備考:\n- primary rate_limitが残っていてもsecondaryで429になるため、指数バックオフで吸収します。