KeyAction: use static KeyNames.getName() instead of instantiating class. #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm reverting the change to |
Contributor
Author
|
@pspeed42 still interested in this PR? |
Contributor
|
I really wish I had a better workflow to notice these messages from GIT... this one was nicely directly in my main in-box at least. The new way is definitely "better" in some ways. I don't have a strong opinion beyond that. |
Contributor
|
I'm finally trying to catch up to all of my open pull requests but this one seems to be in a weird state. Sorry I've been so delinquent in applying these patches. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.