Add flags with default variables for autoscaling and batch version#2768
Draft
chlunde wants to merge 1 commit intojaegertracing:mainfrom
Draft
Add flags with default variables for autoscaling and batch version#2768chlunde wants to merge 1 commit intojaegertracing:mainfrom
chlunde wants to merge 1 commit intojaegertracing:mainfrom
Conversation
If these valuese are not initialized, the generator code will produce invalid kubernetes objects when generating manifest files. In operator mode, the default values were automatically detected. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
- Coverage 74.74% 74.73% -0.02%
==========================================
Files 124 124
Lines 10497 10499 +2
==========================================
Hits 7846 7846
- Misses 2454 2456 +2
Partials 197 197 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
If these valuese are not initialized, the generator code will produce
invalid kubernetes objects when generating manifest files.
In operator mode, the default values were automatically detected.
Fixes #2767
Description of the changes
Set default flag values
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test