Skip to content

Conversation

@Nischal1425
Copy link

@Nischal1425 Nischal1425 commented Feb 3, 2026

Which problem is this PR solving?

Description of the changes

  • Introduces an initial scaffold for a natural language -> trace query
    translation layer.
  • Adds a dedicated nlquery package collocated with the jaegerquery
    extension.
  • Defines a constrained result type that reuses existing
    TraceQueryParams to ensure deterministic behavior.
  • No runtime behavior is changed in this PR.

How was this change tested?

  • Not applicable at this stage (structural scaffold only).
  • Unit tests and functional behavior will be added in follow-up PRs.

Checklist

  • I have read the contributing guidelines
  • I have signed all commits
  • I have added unit tests for the new functionality (planned next)
  • I have run lint and test steps successfully (not required yet for scaffold)

Signed-off-by: Nischal015 <nischal.infinity@gmail.com>
Signed-off-by: Nischal015 <nischal.infinity@gmail.com>
@Nischal1425 Nischal1425 force-pushed the nl-search-scaffold branch 2 times, most recently from 9d0c8c6 to 9f6cbb8 Compare February 5, 2026 09:12
@Nischal1425 Nischal1425 marked this pull request as ready for review February 5, 2026 09:19
@Nischal1425 Nischal1425 requested a review from a team as a code owner February 5, 2026 09:19
@dosubot dosubot bot added the enhancement label Feb 5, 2026
@kunalsanga
Copy link

This scaffold aligns well with the mentorship goal of keeping things deterministic and non-AI-first.

One thought for future extensibility: would it make sense to define a small interface (e.g. IntentExtractor or similar) here, so that this rule-based parser and a future AI-backed extractor can be swapped without touching the query path?

@Nischal1425
Copy link
Author

Thanks for the suggestion, and i agree this make sense.
for this initial PR i intentionally kept the scaffold concrete to validate placement and data flow first. Once the contract is exercised a bit more for example, with LangChainGo-backed extraction, introducing a small interface like IntentExtractor to swap implementations without touching the query path sounds like a good next step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants