Improve provider naming consistency#7978
Improve provider naming consistency#7978aaryan359 wants to merge 2 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: aaryan359 <aaryanmeena96@gmail.com>
|
@jkowall and @yurishkuro, is this looking good? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7978 +/- ##
==========================================
- Coverage 95.60% 95.57% -0.03%
==========================================
Files 316 316
Lines 16773 16773
==========================================
- Hits 16035 16031 -4
- Misses 577 580 +3
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses a TODO comment regarding naming consistency in the remote sampling extension by renaming the strategyProvider field to provider. This is a refactor that improves code clarity by better distinguishing providers from stores.
Changes:
- Renamed the
strategyProviderstruct field toproviderin thersExtensiontype - Updated all references to use the new field name throughout the implementation and tests
- Removed the TODO comment that requested this change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/jaeger/internal/extension/remotesampling/extension.go | Renamed struct field from strategyProvider to provider and updated all 6 references in the implementation |
| cmd/jaeger/internal/extension/remotesampling/extension_test.go | Updated test to use the renamed provider field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jkowall @yurishkuro, I need to update something else, or does this look good? |
|
@jkowall any update on this? |
Which problem is this PR solving?
Description of the changes
strategyProviderfield toproviderto better reflect its type (samplingstrategy.Provider)adaptiveStore)How was this change tested?
Checklist
jaeger:make lint test