Open
Conversation
Signed-off-by: Aaron Lamoreaux <alamoreaux@janestreet.com>
Contributor
Author
|
@Xyene This is from last week, but I just forgot to actually post the PR. |
Contributor
|
Hi Aaron. This looks great, but would you please fix the conflict before I merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #212, this PR shows the source of each call in the args shown given we already have that information. Overall pretty simple, but I modified the calls to store where they were called from or whether it was unknown (thus also removing
from_untraced). It shows the information assource_followed by each of symbol, offset, and address as different args.