Conversation
…for weather station models #673
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request expands the datapoint (DPS) detection ranges in the detect_available_dps method of XenonDevice.py to improve device compatibility. The update adds two new range sets: [50-70] and [111-140], extending coverage beyond the previously checked ranges.
Changes:
- Expanded DPS detection to include ranges [50-70] and [111-140]
- Updated inline documentation to reflect the new ranges
- Split the new ranges into multiple sub-ranges to respect the 255-byte payload limitation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the range of datapoints checked when detecting which datapoints are supported by a device in the
detect_available_dpsmethod. The update ensures broader compatibility with devices that may use additional datapoint ranges.Datapoint detection improvements:
detect_available_dpswithinXenonDevice.pyto include[50-70]and[111-140], in addition to the previously checked ranges, for more comprehensive device support.See #673