Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=========================================
- Coverage 57.8% 34.0% -23.7%
=========================================
Files 39 39
Lines 2497 2477 -20
Branches 73 71 -2
=========================================
- Hits 1441 840 -601
- Misses 1041 1566 +525
- Partials 15 71 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is more a design question, so not to me to decide, but: In my mind this is not the solution but only a workaround. Users of the library have to know that they need to use Since we're already special-casing
Only users part of the repo can be added as reviewers, and are in the suggestion. |
|
I like your idea, I would happily change it. I want to point out what I think is the reason why there are this exceptions. I think it is because of space, numbers and booleans use much more space than pickle serialized objects. |
Fixes: #595
Added
enforce_encodingoption for encoding even bool and int using serializer when this behavior is wanted.@syphar for some strange reason I can't add you in the reviewers and it did not even suggest you when I was tagging you