feat(django-redis): add set functionality to default client#654
feat(django-redis): add set functionality to default client#654alirezaei1380 wants to merge 2 commits intojazzband:masterfrom
Conversation
|
Thanks for your work! Wondering if there are any blockers for landing this atm. Let me know if I can be of any help. |
WisdomPill
left a comment
WisdomPill
left a comment
There was a problem hiding this comment.
sorry for the long delay, it looks good but I think some methods are missing
could you please add a CHANGELOG file?
| @omit_exception | ||
| def sinter(self, *args, **kwargs): | ||
| return self.client.sinter(*args, **kwargs) | ||
|
|
| @omit_exception | ||
| def smembers(self, *args, **kwargs): | ||
| return self.client.smembers(*args, **kwargs) | ||
|
|
| @omit_exception | ||
| def srem(self, *args, **kwargs): | ||
| return self.client.srem(*args, **kwargs) | ||
|
|
| self, | ||
| dest: Any, | ||
| *keys, | ||
| version: Optional[int] = None, |
There was a problem hiding this comment.
maybe here we would like to have two versions? version of set A and version of set B
There was a problem hiding this comment.
Is alirezaei1380#1 kinda what you had in mind for the multiple versions?
There was a problem hiding this comment.
yes, but please use camel_case... I am really sorry for the late reply
There was a problem hiding this comment.
If you're referring to the version* args, I've changed them to be snake_case. Lmk if I misinterpreted anything.
Hoping the author accepts this PR soon.
Signed-off-by: Aalekh Patel <aalekh@protectchildren.ca>
|
Is this getting added or merged soon? or what is the alternative to using the set methods like srem .etc |
|
sorry for the big delay, didn't work much on django-redis in the past months... could you create a new PR or align with master please? |
4 participants
This PR solves #597 and adds all set functionality