Use default value when fetching prefix+ '_URL'#137
Open
moisesguimaraes wants to merge 1 commit intojd:masterfrom
Open
Use default value when fetching prefix+ '_URL'#137moisesguimaraes wants to merge 1 commit intojd:masterfrom
moisesguimaraes wants to merge 1 commit intojd:masterfrom
Conversation
When a driver does not register an environment variable suffixed with _URL, pifpaf will break having None when it expects a string. Signed-off-by: Moisés Guimarães de Medeiros <guimaraes@pm.me>
moisesguimaraes
force-pushed
the
fix-env-url
branch
from
8940379 to
46ee565
Compare
Owner
|
Could we add a test? It seems travis does not work anymore, we might need to fix that too :( |
Contributor
Author
|
Travis is timing out on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a driver does not register an environment variable suffixed with _URL, pifpaf will break having None when it expects a string.