This repository was archived by the owner on Jan 7, 2023. It is now read-only.
Fix output size (Crop is then just a region selector)#109
Open
davidgarciaanton wants to merge 3 commits intojdamcd:masterfrom
Open
Fix output size (Crop is then just a region selector)#109davidgarciaanton wants to merge 3 commits intojdamcd:masterfrom
davidgarciaanton wants to merge 3 commits intojdamcd:masterfrom
Conversation
|
how do i fix the region size then??? |
Author
|
using the fix* methods when building crop. Note that they're not compatible with max output file dimensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch to allow set a desired fixed dimension size (relative to output image), then user can only move the region but not resize it.
Sadly I've done this work because I didn't see in advance that there was already a PR with same purpose.
This PR also adds the fix to smallest size method.