Fix nested JDK layouts (Azul JDK 8) #248 #259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use find command to locate bin directory at variable depths - Add validation for javac executable - Preserve macOS special handling - Add error messages for invalid structures Includes test script to verify logic works for: - Standard single-level structure - Azul 8 double-nested structure - Triple-nested edge case Fixes jeka-dev#248
Some JDK distributions (notably Azul JDK 8) unpack with additional directory levels, causing the launcher to fail locating JAVA_HOME. This change makes JDK detection more robust by: - Locating the JDK via the presence of bin/javac instead of assuming a fixed layout - Handling macOS .jdk bundles (Contents/Home/bin) explicitly - Normalizing the extracted JDK so JAVA_HOME always points to the cache root This preserves existing behavior for standard layouts while fixing nested JDK structures.
PavaraM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where some JDK distributions (e.g. Azul JDK 8)
unpack with additional directory levels, causing the launcher to fail
locating bin/java / bin/javac.
Instead of assuming a fixed archive structure, the launcher now:
Locates the JDK by searching for bin/javac (ensuring a real JDK, not a JRE)
Handles macOS .jdk bundles via Contents/Home/bin
Normalizes the extracted JDK so JAVA_HOME always points to the cache root
This keeps existing behavior unchanged for standard Temurin layouts
while making JDK detection resilient across vendors.
Fixes #248.