chore(deps): update dependency solhint to v6#1469
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 8d2c7e0 in 35 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:59
- Draft comment:
Updated solhint to v6.0.0. Ensure that your solhint configuration is updated to reflect any breaking changes (e.g. removed or promoted rules) introduced in this version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency update, specifically the solhint version. It suggests ensuring that the configuration is updated to reflect any breaking changes. According to the rules, comments on dependency changes or library versions should be ignored, especially if they are not recognized. This comment seems to fall under that category.
2. package.json:59
- Draft comment:
Review solhint config files for compatibility with v6.0.0 changes. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to review configuration files for compatibility with a new version. It doesn't provide a specific suggestion or point out a specific issue in the code. It falls under the category of asking the author to ensure compatibility, which is against the rules.
Workflow ID: wflow_d52y7xsfiqhhLYBQ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
8d2c7e0 to
8953e4a
Compare
8953e4a to
36a3efe
Compare
36a3efe to
246e7c1
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/itman?upgradeToPro=build-rate-limit |
246e7c1 to
f017775
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/itman?upgradeToPro=build-rate-limit |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
f017775 to
12a177b
Compare
12a177b to
5a3aa12
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/itman?upgradeToPro=build-rate-limit |
5a3aa12 to
a5a77ad
Compare
a5a77ad to
1f2a6fd
Compare
1f2a6fd to
be830cc
Compare
be830cc to
9415100
Compare
This PR contains the following updates:
5.0.3→6.0.3Release Notes
protofire/solhint (solhint)
v6.0.3Compare Source
🛠️
Fix: removed unused files, normalized schema for validation, load-rules, base-checker and validator improvements🛠️
Fix: removing console log from use-natspec rule (thanks brossetti1!!)🛠️
Fix: misc minor issues and typos. General polish and stability✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.2Compare Source
🛠️
Fix: corrected use-natspec enforcement behavior on internal functions🛠️
Fix: misc minor issues and typos. General polish and stability🆕
Rule: addedfoundry-no-blockto detect usage ofblock.timestampandblock.numberin Solidity tests🆕
Rule: addedno-unused-private-functionsto prevent unused private function declarations🆕
Rule: addedno-immutable-before-declarationto enforce correct immutable declaration order🧱
Enhancement: improvements tofoundry-test-functionrule, including naming and configuration updates🧰
Infra: update GitHub Actions in CI workflows to v5 and v6. Keeps CI aligned with latest ecosystem changes🧰
Infra: bump js-yaml dependency following security recommendations🧹
Chore: stop publishing the test directory to npm packages. Reduces package size and noise🧹
Chore:foundry-test-functionsis deprecated and will be removed in v7.0.0. Please rename tofoundry-test-function-naming.WILL BE REPLACED IN v7
✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.1Compare Source
🛠️
Fix:no-unused-varsfor modifiers🛠️
Fix:no-unused-importshandled for multiline @inheritdoc. Eliminates missed detections with multiline inheritance docs🛠️
Fix:func-name-mixedcaseimprovement, added snake case exception in interface (naming). Aligns interface naming edge cases🛠️
Fix: misc minor issues; docs link and typos. General polish and stability🧰
Infra: Update GitHub Actions in CI workflows. Keeps CI up to date and consistent across jobs🧰
Infra: Ignore enhancement to mimic as regular linters🧹
Chore: Remove fs-extra dependency. Simplifies deps🧹
Chore: Remove strip-ansi. Cleans unused/legacy deps🧹
Chore: Changed changelog format🧱
Enhancement: added config for no-unused-vars to validate parameters or not🧱
Validation: Improve AJV schema validation and related caching approach. More robust/faster config validation✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.0Compare Source
BREAKING CHANGE
Some rules were removed from the recommended ruleset and other were promoted. See below:
Rules revision - #692
🟥 DEMOTED
payable-fallback: Outdated due to the introduction of receive(); rarely needed in modern Solidity.✅ PROMOTED
interface-starts-with-i: Promotes clarity by clearly distinguishing interfaces from contracts.gas-calldata-parameters: Encourages optimal memory usage for external functions.gas-increment-by-one: Suggests using ++i style for gas-efficient increments.gas-indexed-events: Improves event indexing for off-chain systems and reduces gas usage.gas-small-strings: Recommends cheaper encoding using bytes32 for short strings.gas-strict-inequalities: Helps avoid subtle off-by-one bugs in range conditions.gas-struct-packing: Maximizes storage efficiency by suggesting tight struct packing.duplicated-imports: Prevents redundant imports that bloat the AST and confuse code structure.import-path-check: Ensures all imported files exist and resolve correctly, avoiding runtime errors.function-max-lines: Encourages smaller, more readable and maintainable functions.constructor-syntax: Enforces modern constructor syntax for consistency and clarity.use-natspec: Promotes proper documentation with NatSpec for better audits and readability.Fixed
gas-struct-packingfalse positives - #690gas-increment-by-onebackward expression - #691Added
use-natspec: Promote the use of natspec and make several checks to enforce it - #689v5.2.0Compare Source
Fixed
imports-orderinterference withno-unused-imports- #684Added
cacheflag allowing to skip already evaluated files if no error was thrown and file did not change - #685Thanks to @smol-ninja - @PaulRBerg @lechpzn, @otc-png, @MamunC0der, @kks-code, @RidaMichofi
For making the time of proposing rules, pointing out typos, broken links, unused code, copyright, small reviews, etc. We really appreciate your contributions!
v5.1.0Compare Source
Added
no-unused-import- #648 (Thanks to @DenisGorbachev)Updated
orderingrule - #656BREAKING CHANGE
solhint:defaultruleset - #654Thanks to @fanqiaojun, @maximevtush, @MaxweLL22-22, @PixelPil0t1, @wgyt, @operagxsasha, @Hopium21, @leopardracer, @omahs, @zeevick10, @gap-editor, @Olexandr88, @jirutka
For making the time of pointing out typos, license update, broken links, unused code, copyright, small reviews, etc. We really appreciate your contributions!
v5.0.5Compare Source
Fixed
gas-custom-errors#620 - Support for Custom Errors insiderequirestatementscompiler-version#621 - Upgraded minimum requirement for the rulereentrancy#622 - Fixed path and typosAdded
v5.0.4Compare Source
Fixed
imports-order#595 - Replaced single quotes with double quotesgas-custom-errors#613 - Allows the use of Requirement with Custom Errorssolidity-parserdependency #612Added
.pre-commit-hooks.yamlto allow projects to run Solhint via pre-commit #596 (Thanks to @dbast)huskysince it is not needed #612Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.