Skip to content

Clean up HTTP authentication reference and Update constructors#562

Open
programbeginnerTW wants to merge 6 commits intojenkinsci:masterfrom
programbeginnerTW:Clean-up-HTTP-authentication-code-references
Open

Clean up HTTP authentication reference and Update constructors#562
programbeginnerTW wants to merge 6 commits intojenkinsci:masterfrom
programbeginnerTW:Clean-up-HTTP-authentication-code-references

Conversation

@programbeginnerTW
Copy link

  1. Clean up HTTP authentication reference
  2. Update constructors in JiraSite.java and JireSiteTest.java
  3. Leave the @Deprecated annotation in case any error should occur
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

2. Update constructors in JiraSite.java and JireSiteTest.java
3. Leave the `@Deprecated` annotation in case any error should occur
groupVisibility,
roleVisibility,
useHTTPAuth);
useHTTPAuth,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamy I think this whole if migration block is there for a long time as well, everyone should have already migrated those credentials so I propose to drop this whole if as well?

@programbeginnerTW
Copy link
Author

Is there anything I should do toward this pull request? @rantoniuk

@olamy
Copy link
Member

olamy commented Jul 26, 2023

I don't remember if this is serialized or not? because changing a field will break existing configuration

@rantoniuk
Copy link
Member

@olamy correct me if I'm wrong, but from what I remember, everything that is not @transient is serialized when JiraSite is saved.

So we would need to:

  • deprecate the constructor and the field that we want to drop + make that field transient
  • release that
  • and afterwards in the next release cycle drop everything

(or alternatively again write some "migrator" that we did already in the past, but I'm just looking for a simpler solution..) When I have some time, I'll try to run some local tests to see which approach works, but maybe you already know what to suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants