Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit Poll Workspace #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Explicit Poll Workspace #247
Changes from all commits
5529e902dd95c0e3da693a22f6ebFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 65 in src/main/java/org/jenkinsci/plugins/p4/changes/P4PollRef.java
HE_EQUALS_USE_HASHCODE
Raw output
<p> This class overrides <code>equals(Object)</code>, but does not override <code>hashCode()</code>, and inherits the implementation of <code>hashCode()</code> from <code>java.lang.Object</code> (which returns the identity hash code, an arbitrary value assigned to the object by the VM). Therefore, the class is very likely to violate the invariant that equal objects must have equal hashcodes.</p> <p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable, the recommended <code>hashCode</code> implementation to use is:</p> <pre><code>public int hashCode() { assert false : "hashCode not designed"; return 42; // any arbitrary constant will do } </code></pre>Check warning on line 77 in src/main/java/org/jenkinsci/plugins/p4/changes/P4PollRef.java
Not covered lines
Check warning on line 411 in src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
Partially covered line
Check warning on line 613 in src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
Partially covered line
Check warning on line 1299 in src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
Not covered line
Check warning on line 1425 in src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
Not covered lines
Check warning on line 643 in src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java
Not covered lines
Check warning on line 311 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Partially covered line
Check warning on line 313 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Not covered lines
Check warning on line 324 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Partially covered line
Check warning on line 337 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
HE_USE_OF_UNHASHABLE_CLASS
Raw output
Check warning on line 341 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Not covered lines
Check warning on line 405 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Partially covered line
Check warning on line 410 in src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
Not covered lines
Check warning on line 423 in src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java
Partially covered line
Check warning on line 448 in src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java
Not covered lines
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.