add geo (toBeGeoLatitude, toBeGeoLongitude)#538
Open
verdecchia wants to merge 3 commits intojest-community:mainfrom
Open
add geo (toBeGeoLatitude, toBeGeoLongitude)#538verdecchia wants to merge 3 commits intojest-community:mainfrom
verdecchia wants to merge 3 commits intojest-community:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 75 +2
Lines 673 685 +12
Branches 289 293 +4
=========================================
+ Hits 673 685 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
@verdecchia could you resolve the conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
add geographic assertions (toBeGeoLatitude, toBeGeoLongitude)
Why
I've been using jest and jest-extended for long. Few months ago I needed to make geographic
assertions to a project I was working on but I didn't found anything already done so I wrote
some custom code in my project and later refactored and open sourced to a library
(https://www.npmjs.com/package/check-geographic-coordinates). Other developers finded it useful
and used it, some of them gave to me some feedbacks in how to improve it, but I was missing the
most important one, the jest assertion syntax integration. So I decided to look at jest-exteded
more in deep, not as the user I was, but as a developer and I made this PR. Looking backward
I think I would used it directly with jest-extended.
I hope you like it and that you find useful for other developers too.
I'm glad to receive any feedback from you. Thank you, Marco Verdecchia.
Notes
Assertions based on https://www.npmjs.com/package/check-geographic-coordinates
Housekeeping