Implement toMatchInlineDiffSnapshot custom matcher#339
Open
domsli wants to merge 1 commit intojest-community:masterfrom
Open
Implement toMatchInlineDiffSnapshot custom matcher#339domsli wants to merge 1 commit intojest-community:masterfrom
toMatchInlineDiffSnapshot custom matcher#339domsli wants to merge 1 commit intojest-community:masterfrom
Conversation
domsli
changed the title
toMatchInlineDiffSnapshot custom matcher (#330)toMatchInlineDiffSnapshot custom matcher
domsli
force-pushed
the
domsli/inline-diff-snapshot
branch
from
23eead3 to
6ba8535
Compare
Author
|
@thymikee is this something you would be able to look at? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #330 for why we want this change.
I manually checked the overall change locally by trying the matcher in a separate project: https://github.com/domsli/snapshot-inline-diff-test-app/blob/master/src/App.test.tsx
Some things to note on what was checked:
-uflag