Conversation
This was referenced Jan 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in service of the following missions:
HT @aarondandy who put in lots of legwork to motivate the work (and various other discussions on the DDD-CQRS-ES Slack)
Components:
Handlerfunctions to be written without F# interop (FuncConvertetc) littering the place (open to PRs to do more, but for now the key synchronous one is ported and life will go on)Aggregate.fsto C#Todo.fsto C#TodosController.fsto C#equinox-web-csharpas a component within theEquinox.Templatesnuget (consumption experience should only differ in having to specify a-l C#, i.e. it should go in sharing the same identity as the F# one)Infrastructure.cs, but if any tweaks and/overloads are needed in the Equinox repo, that'll be done - i.e. this may be experimental, but C# support is intended to be a first class supported thing) - see Tweaks for C# interop equinox#81 - this will merge after final integration test against1.0.3-rc1packages1.1.0-rc3per readme in this brancheqxwebC# template by using OneOf library to pattern match #6 in here (but probably not the OneOf ref)Future work:
Encode/TryDecodeimplementation that's presently in place (I really believe its worth doing this work, even if the likelihood of one doing that for any sustained period is not the most likely)