feat(CosmosStore): Expose ISyncContext.SessionToken#195
Draft
feat(CosmosStore): Expose ISyncContext.SessionToken#195
Conversation
ca37dac to
9bb0650
Compare
9bb0650 to
40b1387
Compare
ac7e783 to
4305b88
Compare
cd5febc to
e92891c
Compare
22cfdd4 to
644aaa2
Compare
b1a5694 to
a7486eb
Compare
1919c31 to
b7e2207
Compare
fe2af41 to
edda98d
Compare
7053335 to
07a8d79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes a
SessionTokenonEquinox.Core.ISyncState, which enables logic in aServiceto access that (along with theVersionplumbed in #194) via theQueryExandTransactAsyncExAPIs. More importantly, it enables one to flow theSessionTokenout to the caller in order to enable Read-Your-Writes guarantees for a system's overall client session.This could be merged in the 2.0 timeframe, but leaving it in the 3.0 milestone for now as doing so only makes sense if
Equinox.Cosmos(or another store) actually wires through theSessionTokencorrectly, which involves addressing #192:Equinox.Stream, one needs to be able to supply the incomingSessionToken(maybe add asessionTokenargument inResolve?Loadinternally, the suplied token needs to be passed in the OptionsStreamTokenthat's yielded backcc @thednaz @ylibrach