fix: outdated cmd wasn't check for real new versions#2528
Open
guerinoni wants to merge 1 commit intojetify-com:mainfrom
Open
fix: outdated cmd wasn't check for real new versions#2528guerinoni wants to merge 1 commit intojetify-com:mainfrom
guerinoni wants to merge 1 commit intojetify-com:mainfrom
Conversation
guerinoni
force-pushed
the
fix-outdated
branch
from
df2fca9 to
39d7fb1
Compare
guerinoni
force-pushed
the
fix-outdated
branch
from
39d7fb1 to
d90dcaa
Compare
mikeland73
reviewed
Mar 14, 2025
| } | ||
|
|
||
| // isGreater returns true if v1 is greater than v2 | ||
| func isGreater(v1, v2 string) bool { |
Collaborator
There was a problem hiding this comment.
I wish it was this simple :(
Unfortunately, nix package versions don't follow any convention. Some (many) use semver, but many do not.
We have some pretty complicated logic to try to do this on the search server. I can look into open sourcing it so you can use it here.
Contributor
Author
There was a problem hiding this comment.
Let me know, for now this can be enough for doing this dirty job :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously this only checks on lockfile.
How was it tested?
Manually on a project I'm working on, and I figured out it was not working correctly.