feat(Docker): Added Docker file + compose for local dev#22
Open
timothystewart6 wants to merge 10 commits intojetkvm:devfrom
Open
feat(Docker): Added Docker file + compose for local dev#22timothystewart6 wants to merge 10 commits intojetkvm:devfrom
timothystewart6 wants to merge 10 commits intojetkvm:devfrom
Conversation
6e10356 to
9002e20
Compare
9002e20 to
427d3c8
Compare
d812f22 to
3557bbe
Compare
3557bbe to
8651ef2
Compare
This was referenced Feb 22, 2025
IDisposable
reviewed
Sep 22, 2025
| - postgres | ||
| volumes: | ||
| - .:/app | ||
| command: ["sh", "-c", "npm install && npm run dev"] |
Contributor
There was a problem hiding this comment.
Wouldn't npm ci && npm run dev be more intentional about packages?
IDisposable
requested changes
Sep 22, 2025
| # Base Stage | ||
| FROM node:22.14.0-bullseye-slim AS base | ||
| WORKDIR /app | ||
| COPY package.json package-lock.json ./ |
Contributor
There was a problem hiding this comment.
This really should be be moved down.
FROM base AS deps
COPY package.json package-lock.json ./
RUN npm ci| CMD ["sh", "-c", "npm run dev"] | ||
|
|
||
| # Production Stage | ||
| FROM node:22.14.0-bullseye-slim AS prod |
Contributor
There was a problem hiding this comment.
This could be
FROM base AS prod(and the WORKDIR line here deleted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #20 and #19
I tried to keep this PR minimal but it kept growing as I needed to make sure that the production container could build
docker compose up --buildto start the local envDocker build commands