feat(ui): add always-visible ATX LED status indicators#1099
feat(ui): add always-visible ATX LED status indicators#1099nitishagar wants to merge 1 commit intojetkvm:devfrom
Conversation
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
The UI needs a localization pass
|
Thanks for the thorough review @IDisposable! I've addressed all the comments. Please take a look when you get a chance. |
|
@IDisposable Thanks. Can you take another look? |
|
@IDisposable Thanks for the review. Is this going to be merged automatically? |
@adamshiervani or @ym are actual code owners so they do the mainline merges. After it's merged, we will need to do a localization pass for all the other languages (you can do so with |
- Add ATXStateIndicator component to ActionBar - Show Power/HDD LED status when ATX extension is active - Add popover with Power/Reset buttons for quick access - Add confirmation dialogs for power actions to prevent accidents Note: Long-press support for force power off can be added in a future iteration - the backend already supports "power-long" action. Fixes jetkvm#729
|
@IDisposable Thanks. I've run the machine translation and added localizations for all supported languages (da, de, es, fr, it, nb, sv, zh). |
|
|
2 participants
Note: Long-press support for force power off can be added in a future iteration - the backend already supports "power-long" action.
Fixes #729