Skip to content

feat: increase api limit for data loads#1526

Open
paustint wants to merge 2 commits intomainfrom
feature/increase-batch-size-1521
Open

feat: increase api limit for data loads#1526
paustint wants to merge 2 commits intomainfrom
feature/increase-batch-size-1521

Conversation

@paustint
Copy link
Contributor

@paustint paustint commented Feb 4, 2026

increase the limit for the number of batches in one data load

Add higher limit for paid users vs free users

resolves #1521


fix: retain permission manager filter text on tab change

When a tab is changed, retain the filtered text the user entered
since the rows remain filtered

resolves #1525

increase the limit for the number of batches in one data load

Add higher limit for paid users vs free users

resolves #1521
When a tab is changed, retain the filtered text the user entered
since the rows remain filtered

Ref: resolves #1525
Copilot AI review requested due to automatic review settings February 4, 2026 13:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements two separate features as described in the linked issues:

  1. Increased API limits for data loads: Raises the limit from 250 API calls to 1,000 for free users and 5,000 for paid users, with no limit for desktop and browser extension users
  2. Filter text retention in permission manager: Maintains filter text when switching between tabs in the manage permissions interface

Changes:

  • Added dynamic API limit calculation based on user plan type (free/paid) and platform (web/desktop/extension)
  • Introduced a warning at 250 API calls and separate error limits at 1,000/5,000 calls depending on user plan
  • Threaded filter text through all permission manager table components to retain user input when switching tabs
  • Updated documentation to reflect new API limits

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/shared/ui-core/src/state-management/load-records.state.ts Implements dynamic API limit logic with tiered limits based on user plan and platform, adds warning vs error distinction
libs/shared/ui-core/src/load/load-records-utils.tsx Removes obsolete MAX_API_CALLS constant
libs/features/load-records/src/steps/PerformLoad.tsx Integrates API limit warning display in the UI
libs/types/src/lib/ui/permission-manager-types.ts Adds optional filterValue property to context type
libs/features/manage-permissions/src/utils/permission-manager-table-utils.tsx Updates SearchInput to use filterValue from context
libs/features/manage-permissions/src/ManagePermissionsEditorObjectTable.tsx Accepts and passes filterText prop to context
libs/features/manage-permissions/src/ManagePermissionsEditorTabVisibilityTable.tsx Accepts and passes filterText prop to context
libs/features/manage-permissions/src/ManagePermissionsEditorFieldTable.tsx Accepts and passes filterText prop to context
libs/features/manage-permissions/src/ManagePermissionsEditor.tsx Passes filter state variables to table components
apps/docs/docs/load/load.mdx Documents new API limit tiers for different user plans

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

label="Batch Size"
isRequired
hasError={!!batchSizeError || !!batchApiLimitError}
hasError={!!batchSizeError || !!batchApiLimitError || !!batchApiLimitWarning}
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning should not be treated as an error. Setting hasError to true when there's only a warning will make the field appear invalid (likely with red styling) even though it's just informational. The warning message can still be displayed without setting hasError to true. Consider displaying the warning separately or only setting hasError for actual errors (batchSizeError and batchApiLimitError).

Suggested change
hasError={!!batchSizeError || !!batchApiLimitError || !!batchApiLimitWarning}
hasError={!!batchSizeError || !!batchApiLimitError}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage permissions: text filter not retained, but records remain filtered Increase limit for number of API requests for data load

1 participant