Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements two separate features as described in the linked issues:
- Increased API limits for data loads: Raises the limit from 250 API calls to 1,000 for free users and 5,000 for paid users, with no limit for desktop and browser extension users
- Filter text retention in permission manager: Maintains filter text when switching between tabs in the manage permissions interface
Changes:
- Added dynamic API limit calculation based on user plan type (free/paid) and platform (web/desktop/extension)
- Introduced a warning at 250 API calls and separate error limits at 1,000/5,000 calls depending on user plan
- Threaded filter text through all permission manager table components to retain user input when switching tabs
- Updated documentation to reflect new API limits
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/shared/ui-core/src/state-management/load-records.state.ts | Implements dynamic API limit logic with tiered limits based on user plan and platform, adds warning vs error distinction |
| libs/shared/ui-core/src/load/load-records-utils.tsx | Removes obsolete MAX_API_CALLS constant |
| libs/features/load-records/src/steps/PerformLoad.tsx | Integrates API limit warning display in the UI |
| libs/types/src/lib/ui/permission-manager-types.ts | Adds optional filterValue property to context type |
| libs/features/manage-permissions/src/utils/permission-manager-table-utils.tsx | Updates SearchInput to use filterValue from context |
| libs/features/manage-permissions/src/ManagePermissionsEditorObjectTable.tsx | Accepts and passes filterText prop to context |
| libs/features/manage-permissions/src/ManagePermissionsEditorTabVisibilityTable.tsx | Accepts and passes filterText prop to context |
| libs/features/manage-permissions/src/ManagePermissionsEditorFieldTable.tsx | Accepts and passes filterText prop to context |
| libs/features/manage-permissions/src/ManagePermissionsEditor.tsx | Passes filter state variables to table components |
| apps/docs/docs/load/load.mdx | Documents new API limit tiers for different user plans |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| label="Batch Size" | ||
| isRequired | ||
| hasError={!!batchSizeError || !!batchApiLimitError} | ||
| hasError={!!batchSizeError || !!batchApiLimitError || !!batchApiLimitWarning} |
There was a problem hiding this comment.
The warning should not be treated as an error. Setting hasError to true when there's only a warning will make the field appear invalid (likely with red styling) even though it's just informational. The warning message can still be displayed without setting hasError to true. Consider displaying the warning separately or only setting hasError for actual errors (batchSizeError and batchApiLimitError).
Suggested change
| hasError={!!batchSizeError || !!batchApiLimitError || !!batchApiLimitWarning} | |
| hasError={!!batchSizeError || !!batchApiLimitError} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
increase the limit for the number of batches in one data load
Add higher limit for paid users vs free users
resolves #1521
fix: retain permission manager filter text on tab change
When a tab is changed, retain the filtered text the user entered
since the rows remain filtered
resolves #1525