Skip to content

Add more clubs to the club picker#11

Merged
jewbetcha merged 2 commits intojewbetcha:mainfrom
trotzig:more-clubs
Jan 30, 2026
Merged

Add more clubs to the club picker#11
jewbetcha merged 2 commits intojewbetcha:mainfrom
trotzig:more-clubs

Conversation

@trotzig
Copy link
Contributor

@trotzig trotzig commented Jan 29, 2026

I was playing around with the UI and noticed that the club selection was a little bit limited. While it's probably okay to use e.g. 5-wood when practicing with a hybrid, I thought it would be better to have the right club in the list. The list is of course not complete ("where's my 1-iron?") but it should be enough for 99.5% of golfers.

I picked enough clubs so that they would be divisible by four. The grid layout looks best with these groups.

@trotzig trotzig requested a review from ggubs as a code owner January 29, 2026 19:20
I was playing around with the UI and noticed that the club selection was
a little bit limited. While it's probably okay to use e.g. 5-wood when
practicing with a hybrid, I thought it would be better to have the right
club in the list. The list is of course not complete ("where's my
1-iron?") but it should be enough for 99.5% of golfers.

I picked enough clubs so that they would be divisible by four. The grid
layout looks best with these groups.
@trotzig
Copy link
Contributor Author

trotzig commented Jan 29, 2026

Hi @jewbetcha! I decided to try out this project locally. Noticed some missing clubs and took it as an opportunity to make a first PR and learn more about the structure. 👋

@jewbetcha jewbetcha self-requested a review January 30, 2026 16:22
Copy link
Owner

@jewbetcha jewbetcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution @trotzig !

@jewbetcha jewbetcha merged commit 041e560 into jewbetcha:main Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants