Wait for page load after login to fix race condition #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
requested changes
Dec 23, 2025
| $submit->click(); | ||
|
|
||
| // Wait for URL change after login (max 3 seconds). | ||
| $timeout = microtime(true) + 3; |
Collaborator
There was a problem hiding this comment.
this option needs to be configurable and should be set to 0 by default to allow users to opt-in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript tests randomly fail with "Unable to determine if logged in"
errors. This happens because
loggedIn()is called immediately afterclicking the login button, before the page redirect and DOM are fully
loaded. The issue is more frequent in CI environments like Jenkins.
Solution proposed
Added "waits ups to X seconds" after login submission to ensure the page transition completes: