kafka: don't require container for non-kafka tests#32364
Open
285729101 wants to merge 1 commit intojhipster:mainfrom
Open
kafka: don't require container for non-kafka tests#32364285729101 wants to merge 1 commit intojhipster:mainfrom
285729101 wants to merge 1 commit intojhipster:mainfrom
Conversation
Remove @ImportTestcontainers(KafkaTestContainer.class) from IntegrationTest annotation so the Kafka container is no longer started for every integration test. Move spring.cloud.function.definition to KafkaResourceIT via @TestPropertySource so the Kafka consumer/producer bindings are only active in tests that actually need them. Closes jhipster#31133
Author
|
@mshima @DanielFran this removes the global Kafka testcontainer injection so non-Kafka test suites don't pay the startup cost. Would appreciate a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ImportTestcontainers(KafkaTestContainer.class)fromIntegrationTestso the Kafka container no longer starts for every integration testspring.cloud.function.definitionout of shared testapplication.ymland intoKafkaResourceITvia@TestPropertySource, so the Kafka consumer/producer bindings only activate in tests that actually need themCloses #31133