Skip to content

Adds Math Party Parrot#267

Open
deedeelavinder wants to merge 1 commit intojmhobbs:masterfrom
deedeelavinder:math_parrot
Open

Adds Math Party Parrot#267
deedeelavinder wants to merge 1 commit intojmhobbs:masterfrom
deedeelavinder:math_parrot

Conversation

@deedeelavinder
Copy link
Contributor

No description provided.

@deedeelavinder deedeelavinder changed the title Adds Math Parrot Adds Math Party Parrot Oct 31, 2018
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 31, 2018

Nice! Can you fix the file size and dimension issues? I'm still trying to sort out the file permissions issue on angelparrot.gif so you can ignore those errors.

  3) gifs in HD should weight less than 64KB:
     AssertionError: mathparrot.gif is too big(97.6318359375 KB)
      at test/size.js:15:13
      at Array.forEach (native)
      at Context.<anonymous> (test/size.js:13:24)
  4) gifs in SD should weight less than 64KB:
     AssertionError: mathparrot.gif is too big(97.6318359375 KB)
      at test/size.js:30:13
      at Array.forEach (native)
      at Context.<anonymous> (test/size.js:28:21)
  5) gifs should never be wider or taller than 128px:
     AssertionError: mathparrot.gif is wider than 128px
      at test/size.js:48:11
      at Array.forEach (native)
      at Context.<anonymous> (test/size.js:45:21)

@deedeelavinder
Copy link
Contributor Author

@jmhobbs Yes! My apologies, I meant to come back and check on Travis. I will fix up tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants