Conversation
| NSStatusBarButton *button = [statusItem button]; | ||
|
|
||
| if ([self.stopwatch isStopped]) { | ||
| [statusItem setLength:26.0]; |
There was a problem hiding this comment.
The docs said setTitle etc. were deprecated and you should now use the button. If this is breaking anything, it can go, of course.
smokris
left a comment
smokris
left a comment
There was a problem hiding this comment.
Oh, I should've explained — when I built your PR and ran it and opened the Preferences window, I got an error message saying that it couldn't connect appearDisabledWhilePausedButton to its outlet in the class PreferencesWindowController (whose property name lacks the Button suffix).
Going the other direction (adding the Button suffix to the property) sounds good to me. I've added those change suggestions.
Fix by @smokris for `Failed to connect (appearDisabledWhilePausedButton) outlet from (PreferencesWindowController) to (NSButton)` Co-Authored-By: Steve Mokris <smokris@softpixel.com>
Fix by @smokris for `Failed to connect (appearDisabledWhilePausedButton) outlet from (PreferencesWindowController) to (NSButton)` Co-Authored-By: Steve Mokris <smokris@softpixel.com>
Fix by @smokris for `Failed to connect (appearDisabledWhilePausedButton) outlet from (PreferencesWindowController) to (NSButton)` Co-Authored-By: Steve Mokris <smokris@softpixel.com>
Fix by @smokris for `Failed to connect (appearDisabledWhilePausedButton) outlet from (PreferencesWindowController) to (NSButton)` Co-Authored-By: Steve Mokris <smokris@softpixel.com>
ErezVolk
force-pushed
the
appear-disabled-while-paused
branch
from
4473c4e to
7f316f0
Compare
|
Update: I upgraded DDHotKey and fixed its usage (looks like you're not supposed to create your own |
2 participants
Thanks for a wonderful little app! Here's something I find useful. I like to be able to tell at a glance whether the timer is paused or not. I've added an option to gray out the time.
This is my first time ever writing anything for OSX, using Xcode, etc, so everything may be horribly wrong.