Conversation
Owner
|
Did you rebuild on that version of iOS? We're not using any APIs that are iOS 11 are we? |
Collaborator
|
I've manually tested the changes above and and it seems fine running iOS 10.3.1 on the simulator, however, only when running Xcode 10.3. Running it in the simulator on Xcode 11.1 mangles the buttons on the syntax selector. Although, it is not the only problem we have found with Xcode 11+ on other projects so at work we have to keep using 10.3 for older projects. This should be fine to merge as long as we use Xcode 10.3 to build and upload to App Store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21