Merged
Conversation
Previously, we would automatically set the name of the screenshot to the most recently played game. This is incorrect for cases where we are not currently _in_ a game, such as in the main ui. To fix this, we now detect minarch.elf - as well as a slew of popular optional emulators - when checking if we should use the game name or a generic name. While this is a bit more annoying to upkeep - especially as folks port other custom emulators - this is a bit better as now we don't errantly mark a screenshot of the UI as a game. Ideally we also detect if another custom pak is launched and use the pak's name as the screenshot name, but this is better than nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would automatically set the name of the screenshot to the most recently played game. This is incorrect for cases where we are not currently in a game, such as in the main ui.
To fix this, we now detect minarch.elf - as well as a slew of popular optional emulators - when checking if we should use the game name or a generic name. While this is a bit more annoying to upkeep - especially as folks port other custom emulators - this is a bit better as now we don't errantly mark a screenshot of the UI as a game.
Ideally we also detect if another custom pak is launched and use the pak's name as the screenshot name, but this is better than nothing.