feat: implement messages when launching the screenshot monitor#4
Merged
josegonzalez merged 1 commit intomainfrom Jan 25, 2025
Merged
feat: implement messages when launching the screenshot monitor#4josegonzalez merged 1 commit intomainfrom
josegonzalez merged 1 commit intomainfrom
Conversation
Instead of just exiting immediately, show a message stating that it is being launched, check if it is running, and then exit as appropriate. Additionally, update process tracking to handle the case where we are launching a script - which doesn't respond as nicely to pgrep - vs a binary. Finally, rename a variable to make it make more sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of just exiting immediately, show a message stating that it is being launched, check if it is running, and then exit as appropriate.
Additionally, update process tracking to handle the case where we are launching a script - which doesn't respond as nicely to pgrep - vs a binary.
Finally, rename a variable to make it make more sense.