fix(rss/atom): sanitize enclosure URLs containing ä
Open
chick-p wants to merge 2 commits intojpmonette:masterfrom
Open
fix(rss/atom): sanitize enclosure URLs containing ächick-p wants to merge 2 commits intojpmonette:masterfrom
ächick-p wants to merge 2 commits intojpmonette:masterfrom
Conversation
Owner
|
@chick-p Thanks for the contribution. Could you provide some simple tests for this please? |
Contributor
|
@chick-p I can't edit the git branch directly, but here are some ideas for minimal tests: The example from the issue could be added as two new test cases - one for RSS and another for Atom: Invalid: <enclosure url="https://example.com/hello&world.png" />Should be sanitized into this: <enclosure url="https://example.com/hello&world.png" />These examples could be wrapped in minimal XML and RSS files to represent full test cases.
|
eaaeb29 to
1aafed9
Compare
Author
|
@jpmonette @Greenheart |
Greenheart
approved these changes
Jan 12, 2026
Contributor
Greenheart
left a comment
There was a problem hiding this comment.
Thanks for adding the tests! This looks good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227.