Open
Conversation
If the time stored in the missing daylight saving hour, MySQL JDBC driver starting from version 8.0.23 will raise this error (https://dev.mysql.com/doc/relnotes/connector-j/en/news-8-0-23.html) If the date time value stored in the column actually is UTC time, then will return string representation of the value, not the time converted to the local time zone.
Member
|
Per discussion in #1091 perhaps this is a "good enough" fix to merge now while we try to figure out a better long-term option? |
Contributor
Author
|
I will work on the new test failures to find out where the environment time zone impacted the results despite that it's set in the tests: |
When time zone is changed, JDBC connection still will contain initial time zone. Therefore we need to recreate connection with the newly set TZ
With AR default timezone set to :local, PostgreSQL driver will try to convert missing DST time and will fail.
Member
|
@kares Any chance you can review this? I think it looks ok but I don't really like seeing Exception String message comparisons (but believe me we have had to do this many times in the history of the JRuby-related projects so I am not saying it is wrong). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the time stored in the missing daylight saving hour, MySQL JDBC driver starting from version 8.0.23 will raise this error (https://dev.mysql.com/doc/relnotes/connector-j/en/news-8-0-23.html).
If the date time value stored in the column actually is UTC time, then it will return a string representation of the value, not the time converted to the local time zone.
More in #1091