Make only last resultset process and only generate one emptyResultSet#1180
Closed
Make only last resultset process and only generate one emptyResultSet#1180
Conversation
Contributor
|
Correct me if I'm wrong, but you used an early exit strategy ? It should work. |
Member
Author
|
@seuros I think what I am trying may not work because getMoreResults may invalid the previous unprocessed resultset. I am going to only do the removal of empty resultset change. |
Member
Author
|
@seuros sorry I did not answer your question either. I added another commit but it was changed to return there only if there was no next statement or no count so it would not exit early. First version would not exit early for sequence of resultsets but would have if it was a query followed by non-resultset statement. So it was partially broken. Also JDBC doesn't allow it making the PR moot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try and reduce how much result set processing or ruby results are made