Fix bug with gem_excludes not being used on bundler gems

[fzakaria]

This is an upstream commit authored by @stalbot.

Unclear why in the original code exclude_gems was set to false if any files were found in the Git gem. It caused the condition to check for config.gem_excludes to not trigger.

(Looks like gem_excludes will not work neither when spec.source is ::Bundler::Source::Path)

Co-authored-by: Steven Talbot steven@looker.com

[fzakaria]

Would a test be needed for this change ?
I'd like to make sure it gets merged.

[fzakaria]

The Travis failures are not related to the change:

Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    jbundler (~> 0.9) java was resolved to 0.9.3, which depends on
      bundler (~> 1.5) java
  Current Bundler version:
    bundler (2.1.4)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

[kares]

yes, please possibly add a test regardless of CI

[fzakaria]

The unit tests are more complicated -- this might take me a little bit.
I've never heard of DRB :)

What's the state of Warbler ?
Is it still the recommended approach by JRuby to build a JAR?

I'm curious due to the state of the CI.