test: fix the infinite test failing

[radulucut]

No description provided.

[coderabbitai]

Walkthrough

The test Test_Execute_Ping_Infinite in cmd/ping_test.go was updated to adjust timing: the OutputInfinite mock’s sleep increased from 500ms to 1000ms, and the goroutine that sends SIGINT now sleeps 700ms instead of 150ms. No assertions, logic, or control flow were changed, and there were no modifications to exported/public declarations.

Poem

Ping dreams linger a second more,
SIGINT tiptoes in, a touch less swift.
Timers stretch like taffy on the floor,
🕒 waits align, a synchronized shift.
Beep… pause… goodbye—test takes its lift.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

cmd/ping_test.go (2)

326-331: Replace fixed sleep with a start/done barrier to remove flakiness and speed up the test

Relying on a 1s sleep to emulate a long-running OutputInfinite is brittle and slows CI. If scheduling jitters, the cancel goroutine may still miss the exact phase you intend to hit. Use a channel barrier to signal when the last OutputInfinite call starts, and unblock it after sending SIGINT.

Apply this diff within this block:

-	viewerMock.EXPECT().OutputInfinite(expectedMeasurement4).DoAndReturn(func(m *globalping.Measurement) error {
-		time.Sleep(1000 * time.Millisecond)
-		return nil
-	}).After(outputCall6)
+	viewerMock.EXPECT().OutputInfinite(expectedMeasurement4).DoAndReturn(func(m *globalping.Measurement) error {
+		close(startedCh) // signal the last OutputInfinite started
+		<-doneCh         // wait until the test triggers cancellation
+		return nil
+	}).After(outputCall6)

Add these channel declarations near the viewer expectations (above Line 318):

// add near the top of Test_Execute_Ping_Infinite, before setting viewer expectations
startedCh := make(chan struct{})
doneCh := make(chan struct{})

---

348-351: Coordinate SIGINT with the last OutputInfinite instead of sleeping a fixed 700ms

Sleeping 700ms assumes the test has reached the long-running OutputInfinite by then. On a slow or busy CI runner, that assumption can fail. Wait explicitly for the last OutputInfinite to start, then send SIGINT and release the viewer.

Apply this diff within this block:

-go func() {
-		time.Sleep(700 * time.Millisecond)
-		root.cancel <- syscall.SIGINT
-	}()
+go func() {
+		<-startedCh            // ensure we're in the final OutputInfinite call
+		root.cancel <- syscall.SIGINT
+		close(doneCh)          // let OutputInfinite return immediately
+	}()

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5635aca and 5983866.

📒 Files selected for processing (1)

• cmd/ping_test.go (2 hunks)