Skip to content

misc: update deps & go version to 1.24#179

Merged
MartinKolarik merged 1 commit intojsdelivr:masterfrom
radulucut:deps
Nov 24, 2025
Merged

misc: update deps & go version to 1.24#179
MartinKolarik merged 1 commit intojsdelivr:masterfrom
radulucut:deps

Conversation

@radulucut
Copy link
Collaborator

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

This pull request updates the project's Go toolchain and dependencies. The minimum Go version requirement is bumped from 1.23 to 1.24 across CI workflows and the go.mod file. Core dependencies are upgraded, including brotli, cobra, testify, and golang.org/x/term. Additionally, indirect dependencies are refreshed, and new transitive dependencies are introduced to accommodate the toolchain upgrade.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the motivation for the Go version bump and dependency updates, and any testing performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating dependencies and Go version to 1.24, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa5fa99 and fcda8a4.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • .github/workflows/release.yml (2 hunks)
  • .github/workflows/tests.yml (1 hunks)
  • go.mod (1 hunks)
🧰 Additional context used
🔍 Remote MCP

The DeepWiki source encountered issues accessing the repository documentation. Let me search for relevant information about Go 1.24 compatibility and dependency update best practices using general web search.## Summary of Relevant Context for PR Review

Project Context

Globalping-cli is a simple CLI tool to run networking commands remotely from hundreds of globally distributed servers. The project's most recent release (v1.5.0) included updating Go version to 1.23 and updating dependencies, which provides context for this follow-up upgrade to Go 1.24.

Go 1.24 Compatibility Overview

Go 1.24 maintains the Go 1 promise of compatibility, and almost all Go programs are expected to continue to compile and run as before. Go 1.24 maintains backward compatibility while delivering up to 1.5% faster execution on the Go 1 billion benchmarks compared to Go 1.23.

Key Go 1.24 Features

Go modules can now track executable dependencies using tool directives in go.mod, removing the need for the previous workaround of adding tools as blank imports to a file conventionally named "tools.go", and the go tool command can now run these tools. Performance improvements in the runtime have decreased CPU overhead by 2–3% on average across a suite of representative benchmarks, including a new builtin map implementation based on Swiss Tables and more efficient memory allocation of small objects.

Platform Support Changes

On Linux, the kernel version is required to be 3.2 or higher; Go 1.24 is the last version to support macOS 11 Big Sur, and starting from Go 1.25, macOS 12 Monterey or higher will be required. Go 1.24 requires Go 1.22.6 or later for bootstrap.

Dependency Updates Assessment

The go.mod changes include multiple dependency updates to versions that are aligned with Go 1.24 compatibility. The updates to core dependencies (brotli, cobra, testify, x/term, and others) alongside the Go toolchain bump suggest the project maintainers have validated these versions with Go 1.24.

[::web_search::]

🔇 Additional comments (5)
.github/workflows/tests.yml (1)

15-15: Go version matrix update is consistent.

The change properly updates the test matrix to Go 1.24, aligning with the go.mod toolchain bump. No additional workflow adjustments are needed.

.github/workflows/release.yml (1)

23-26: Release workflow Go version updates are consistent.

Both goreleaser and release_linux jobs properly require Go >=1.24, aligning with the toolchain upgrade.

go.mod (3)

30-30: Version bump is routine and safe—no documented breaking changes found.

Based on the search results, golang.org/x/sys v0.38.0 is a routine version tag with no published changelog or breaking-change notices. The absence of documented breaking changes for a Go standard library module typically indicates backward-compatible, incremental updates. The nine-version jump from v0.29.0 to v0.38.0 is normal given the module's release cadence.

No action required unless you need to inspect specific commit details for implementation-level changes.


19-20: No action required—indirect dependencies are legitimate.

Clipperhouse/stringish is a utility module providing generic type constraints for string-like data and UTF-8 operations, while clipperhouse/uax29/v2 implements Unicode Text Segmentation for text tokenization. Both are established, commonly-used Go packages. These are correctly marked as indirect dependencies and are almost certainly pulled in transitively by github.com/spf13/cobra (your direct CLI dependency), which uses text processing under the hood. No suspicious or unnecessary additions detected.


3-3: All dependency updates are verified compatible with Go 1.24.

Cobra v1.10.1, testify v1.11.1, and golang.org/x/term v0.37.0 are all confirmed compatible with Go 1.24. The new indirect dependencies (stringish and uax29/v2) are correctly marked as transitive and are legitimate dependencies from the updated packages. The go.mod structure is sound.


Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinKolarik MartinKolarik merged commit e1fb906 into jsdelivr:master Nov 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants