Open
Conversation
bjohansebas
reviewed
Jan 22, 2026
Comment on lines
+15
to
+30
| export = rangeParser; | ||
|
|
||
| namespace rangeParser { | ||
| export interface Range { | ||
| start: number; | ||
| end: number; | ||
| } | ||
|
|
||
| export interface Result extends Array<Range> { | ||
| type: string; | ||
| } | ||
|
|
||
| export interface Options { | ||
| combine?: boolean; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Is the namespace necessary here, or is it enough to just export it?
Member
Author
There was a problem hiding this comment.
You can't export anything extra because I left it in CommonJS format with export =.
Member
Author
There was a problem hiding this comment.
I tried not to refactor too much in this PR and left that for the perf one, this one is more of a direct port with types added.
blakeembrey
force-pushed
the
be/use-typescript
branch
from
55ff729 to
d94bad8
Compare
blakeembrey
force-pushed
the
be/use-typescript
branch
from
d94bad8 to
391481c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #59. I prefer to author in TypeScript and skip the infrastructure around testing types independently. Uses the same scripts as
path-to-regexpfor automatic formatting and testing.This PR doesn't break backward compatibility in the API (but does in node.js version support). It minimally changes the code and tests to add types and test using
vitest.I plan to add benchmarks (using the built-in
vitestframework) and optimize the code paths (similar to the work done forcookie) in further PRs. I think there's at least a 50% bump available, and that may require minor API changes (e.g. avoid assigning to an object).