Add a custom root component tag.#46
Open
glaubermagal wants to merge 3 commits intojstejada:masterfrom
Open
Conversation
jstejada
requested changes
Apr 15, 2018
Owner
jstejada
left a comment
jstejada
left a comment
There was a problem hiding this comment.
Just a couple of comments inline
package.json
Outdated
| { | ||
| "name": "react-typist", | ||
| "version": "2.0.4", | ||
| "version": "2.0.5", |
Owner
There was a problem hiding this comment.
could you remove these changes? I'll update the version when I publish a new version separately
Author
There was a problem hiding this comment.
Removed in my last commit. Thank you
glaubermagal
commented
Apr 18, 2018
Author
glaubermagal
left a comment
glaubermagal
left a comment
There was a problem hiding this comment.
I put back the version to 2.0.4. Thank you for accepting my merge!
package.json
Outdated
| { | ||
| "name": "react-typist", | ||
| "version": "2.0.4", | ||
| "version": "2.0.5", |
Author
There was a problem hiding this comment.
Removed in my last commit. Thank you
Author
|
Hi @jstejada, are my changes ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a feature capable of changing the root component tag.