[New]: jsx-no-literals: add restrictedAttributes option#3950
Open
ushiboy wants to merge 1 commit intojsx-eslint:masterfrom
Open
[New]: jsx-no-literals: add restrictedAttributes option#3950ushiboy wants to merge 1 commit intojsx-eslint:masterfrom
jsx-no-literals: add restrictedAttributes option#3950ushiboy wants to merge 1 commit intojsx-eslint:masterfrom
Conversation
|
Hello ljharb! 👋 The failing unit-test seems unrelated with the 4 files that were added. It seems like the failures are pre-existing issues in jsx-indent and jsx-tag-spacing. Should we proceed with the PR as-is since these are unrelated issues? And please give us feedback on this PR too! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
restrictedAttributesoption tojsx-no-literalsruleSummary
This PR introduces a new
restrictedAttributesoption for thejsx-no-literalsrule. With this option, you can enforce translation (i18n) only for certain attributes, while other attributes can still use string literals freely.This implementation addresses the main requirements discussed in issue #3003, though it takes a slightly different approach from some of the ideas mentioned there.
Usage Examples
Basic usage – restrict specific attributes globally
Component-specific restrictions