[New] jsx-sort-props: add sortFirst option to explicitly specify prop names to sort first#3965
Open
loderunner wants to merge 3 commits intojsx-eslint:masterfrom
Open
[New] jsx-sort-props: add sortFirst option to explicitly specify prop names to sort first#3965loderunner wants to merge 3 commits intojsx-eslint:masterfrom
jsx-sort-props: add sortFirst option to explicitly specify prop names to sort first#3965loderunner wants to merge 3 commits intojsx-eslint:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3965 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 136 136
Lines 10008 10041 +33
Branches 3717 3732 +15
=======================================
+ Hits 9792 9825 +33
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Converting to draft PR while I address the CI issues. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
Just realized this is likely a duplicate of #3853, opened almost exactly one year ago. 😅 |
This was referenced Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3175 #3639 #3193
Warning
I had to pin the ESLint version in the published types test project, as the ESLint types break with TypeScript 4.0 starting with ESLint 9.39.0. This can also be fixed by dropping support for TypeScript 4.0.
Let me know if I should remove 4.0 from the matrix instead.
Adds a
sortFirstoption to enforce that specified props appear first, in the given order. Takes precedence over other sorting options (reservedFirst,shorthandFirst,callbacksLast,multiline).Examples:
Props in
sortFirstmaintain their specified order relative to each other, and all appear before other props.