feat: add cert reload on SIGHUP #3041
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racterub
requested review from
juanfont,
kradalby,
nblock and
ohdearaugustin
as code owners
Collaborator
|
Without having had time to review, I think this seem reasonable, can you rebase it of main (there has been a lot of changes) and then I'll try to get to reviewing it? |
Add two integration tests to verify the certificate reload functionality: - TestTLSCertificateReloadOnSIGHUP: verifies certificate is reloaded after SIGHUP by checking NotBefore timestamp changes - TestTLSCertificateReloadClientConnectivity: verifies clients remain connected and can ping each other after certificate rotation Also adds Reload() method to ControlServer interface to expose SIGHUP signal capability to integration tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
racterub
force-pushed
the
feat/cert-reload-on-sighup
branch
from
649bdb3 to
5132ecc
Compare
Author
|
Hey @kradalby , I just rebased main. please have a look. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for reloading TLS certificates when headscale receives a SIGHUP signal, enabling zero-downtime certificate rotation for deployments using manual TLS configuration.
Changes
(in addition to existing ACL policy reload)
reloads
certificate updates
Tasks
Fixes #3027
Disclaimer: This PR is implemented full auto by Claude Code and reviewed by me.