Allow initialization of PropertiesFile::Options using C++11 initializer list and C++20 designated initializer#1564
Open
l0ner wants to merge 1 commit intojuce-framework:developfrom
Conversation
…sing Cpp20 Aggregate Initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of a default Ctor for PropertiesFile::Options, prevents initialization of this struct using C++11 Initializer List, or C++20 designated initializers.
This means that PropertiesFile::Option properties need to be set manually, every time referencing the variable that holds the Option resulting in quite repetitive code. Ie:
While using the C++11 initializer list requires all aggregate member values to be specified in order, it results in a bit less repetitive code:
juce::ApplicationProperties userSettings; userSettings.setStorageParameters(juce::PropertiesFile::Options { "MyApp", ".bin", "myAppSettingsDir", "Application Support", true, true, false, 3000, PropertiesFile::StorageFormat::storeAsBinary });By allowing the use of C++20 designated initializer the code can be made terser (and more readable) than the one required when using C++11 initializer list.
juce::ApplicationProperties userSettings; userSettings.setStorageParameters(juce::PropertiesFile::Options { .applicationName = "MyApp", .filenameSuffix = ".bin", .folderName = "myAppSettingsDir", .osxLibrarySubFolder = "Application Support", .storageFormat = juce::PropertiesFile::StorageFormat::storeAsBinary });