Skip to content

Update JaegerPropagator.php#89

Open
NikolaySav wants to merge 4 commits intojukylin:masterfrom
NikolaySav:patch-1
Open

Update JaegerPropagator.php#89
NikolaySav wants to merge 4 commits intojukylin:masterfrom
NikolaySav:patch-1

Conversation

@NikolaySav
Copy link

in 2.1.1-beta extract method can return null instead of SpanContext class

in 2.1.1-beta extract method can return null instead of SpanContext class
@NikolaySav
Copy link
Author

Invalid child_of option. Expected Span or SpanContext, got NULL

opentracing/opentracing/src/OpenTracing/StartSpanOptions.php(164): OpenTracing\Exceptions\InvalidSpanOption::forInvalidChildOf(NULL)
opentracing/opentracing/src/OpenTracing/StartSpanOptions.php(49): OpenTracing\StartSpanOptions::buildChildOf(NULL)

fails on null

@jukylin
Copy link
Owner

jukylin commented Mar 31, 2020

#81 #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants