Skip to content

Support version-specific Manifest#1372

Open
quachpas wants to merge 1 commit intojulia-vscode:mainfrom
quachpas:version-specific-manifest
Open

Support version-specific Manifest#1372
quachpas wants to merge 1 commit intojulia-vscode:mainfrom
quachpas:version-specific-manifest

Conversation

@quachpas
Copy link

Fixes #1316. This is in parallel with julia-vscode/SymbolServer.jl#303. Same comments apply.

This adds to the list of manifest candidates the version-specific Manifest based on the Julia version of the LSP.
There is a strong assumption because in load_project_packages_into_store!, SymbolServer.jl will now prefer in order: Manifest-vX.XX.toml, Manifest.toml, JuliaManifest.toml.
I am not sure whether this is acceptable. If this is approved, then I will documentation at the VS Code extension docs and mention this in the changelog.

For every PR, please check the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Manifest.toml file used in Julia 1.11

1 participant