fix(useScrollLock): correct scrollbarWidth calculation in widthReflow#690
Open
sabertobihwy wants to merge 1 commit intojuliencrn:masterfrom
Open
fix(useScrollLock): correct scrollbarWidth calculation in widthReflow#690sabertobihwy wants to merge 1 commit intojuliencrn:masterfrom
sabertobihwy wants to merge 1 commit intojuliencrn:masterfrom
Conversation
…clientWidth, not scrollWidth)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect scrollbar width calculation in
widthReflow(used byuseScrollLock).The old implementation used
scrollWidth, which returns the total scrollable width — even content that overflows. This made the scrollbar width calculation wrong in some cases.Now it uses
clientWidth, which gives the actual visible area (content + padding, excluding scrollbar), and the result is accurate.